Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

fix: restore ability to resume ++ #619

Merged
merged 1 commit into from
Sep 4, 2022
Merged

fix: restore ability to resume ++ #619

merged 1 commit into from
Sep 4, 2022

Conversation

LordOfPolls
Copy link
Member

also fixes minor gripes i had while debugging

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

This PR restores NAFF's ability to reliably resume a connection to the gateway.

Changes

  • Recompose resume url to account for missing data
  • Fix minor typos, logging levels
  • Restore jitter delay on heartbeater

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls
fix: restore ability to resume ++
e101428 
also fixes minor gripes i had while debugging
@LordOfPolls LordOfPolls added the Bug::Library A bug in the library label Sep 4, 2022
@LordOfPolls
Copy link
Member Author

I'm merging this pr review-less as i'm deeming it urgent

@LordOfPolls LordOfPolls merged commit a9c40ff into dev Sep 4, 2022
@LordOfPolls LordOfPolls deleted the resume-fix branch September 4, 2022 16:33
@LordOfPolls LordOfPolls mentioned this pull request Sep 4, 2022
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug::Library A bug in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LordOfPolls