Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

fix: Fix localisation syncing #614

Merged
merged 5 commits into from
Aug 27, 2022
Merged

fix: Fix localisation syncing #614

merged 5 commits into from
Aug 27, 2022

Conversation

LordOfPolls
Copy link
Member

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

This PR fixes command syncing to accomodate discords bad implimentation of localisation. The changes aren't that extensive but handle weird edge-cases.

This post-processing from this PR was originally from #613 - however it made more sense to be included in this pr

Changes

  • Impliment the with_localization field of command requests that wolf pointed out wasn't commited
  • Handle discord sending NoneType instead of {}
  • Post-process missing attributes of choices

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls added Bug::Library A bug in the library Bug::Discord A bug caused by a discord change labels Aug 23, 2022
@LordOfPolls LordOfPolls merged commit ea05120 into dev Aug 27, 2022
@LordOfPolls LordOfPolls deleted the localisation-in-req branch August 27, 2022 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug::Discord A bug caused by a discord change Bug::Library A bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant