Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

feat: support new ws resume url #594

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Conversation

LordOfPolls
Copy link
Member

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

Discord decided they wanted to break gateway resumes. This fixes that. At least they gave warning this time 🙃

Changes

  • New gateway attribute ws_resume_url
  • Add new parameter to ws.reconnect to make future meddling with ws urls easier
  • Set url param to ws_resume_url on reconnect

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls added Improvement Something that is already implemented but can be done better New Feature::Discord Adding support for a new discord feature labels Aug 10, 2022
@LordOfPolls LordOfPolls changed the base branch from dev to ready-on-restart August 10, 2022 18:33
@LordOfPolls LordOfPolls merged commit 59fc704 into ready-on-restart Aug 10, 2022
@LordOfPolls LordOfPolls deleted the gateway-resume branch August 10, 2022 18:34
LordOfPolls added a commit that referenced this pull request Aug 14, 2022
* feat: unset ready on reconnect

* feat: support new ws resume url (#594)

* fix: handle resume-ready guild create events

do not view the horrors that lay within, simply know they exist, and know they protect you. A necessary evil to defend the weak and protect the holy. To smite the miscreants whom aim to damage your cache
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Improvement Something that is already implemented but can be done better New Feature::Discord Adding support for a new discord feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant