This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
fix: check min/max value in sync comparison #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
|
Is the test failing because of rate limits? |
silasary
approved these changes
Jul 11, 2022
No, its a race condition in the test-bot. Its editing the user, then checking to see if the change was successful. Sometimes it checks the value before discord sends the data. |
|
Ah, we should definitely make the tests more resilient to that 😛 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
Resolves #557 by chceking the min and max attributes for options.
Changes
min_valueandmax_valueto the attributes that are compared in sync detectionChecklist
Python 3.10.x