Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

feat: add support for event cover images #513

Merged
merged 2 commits into from
Jun 5, 2022
Merged

feat: add support for event cover images #513

merged 2 commits into from
Jun 5, 2022

Conversation

LordOfPolls
Copy link
Member

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

Adds support for event cover images

image

Changes

  • As above

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

Copy link
Collaborator

@Wolfhound905 Wolfhound905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current code looks good, but the guild.py create_scheduled_event function was not updated.

async def create_scheduled_event(
self,
name: str,
event_type: ScheduledEventType,
start_time: "models.Timestamp",
end_time: Absent[Optional["models.Timestamp"]] = MISSING,
description: Absent[Optional[str]] = MISSING,
channel_id: Absent[Optional[Snowflake_Type]] = MISSING,
external_location: Absent[Optional[str]] = MISSING,
entity_metadata: Optional[dict] = None,
privacy_level: ScheduledEventPrivacyLevel = ScheduledEventPrivacyLevel.GUILD_ONLY,
reason: Absent[Optional[str]] = MISSING,
) -> "models.ScheduledEvent":

@LordOfPolls
Copy link
Member Author

The current code looks good, but the guild.py create_scheduled_event function was not updated.

I added support for receiving not creating

@LordOfPolls
Copy link
Member Author

There you go

Copy link
Collaborator

@Wolfhound905 Wolfhound905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me. Thank you! 🙂

@LordOfPolls LordOfPolls merged commit 6c7153a into dev Jun 5, 2022
@LordOfPolls LordOfPolls deleted the event-cover branch June 5, 2022 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants