Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

feat: improve sync required detection #512

Merged
merged 1 commit into from
Jun 3, 2022
Merged

feat: improve sync required detection #512

merged 1 commit into from
Jun 3, 2022

Conversation

LordOfPolls
Copy link
Member

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

Fixes a flaw in how the library determines if a interaction command sync is required. Previously it did not check subcommand descriptions, and the wrong name was used for localisations.

This PR makes it far easier to add new attributes to compare, plus it resolves the above.

Changes

  • Seperate command comparison into _compare_commands
  • Actually check subcommand descriptions
  • Use correct key for localisations
  • Refactor comparison list for easier expansion

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls added Bug::Library A bug in the library Improvement Something that is already implemented but can be done better labels Jun 1, 2022
@LordOfPolls LordOfPolls merged commit 7940f29 into dev Jun 3, 2022
@LordOfPolls LordOfPolls deleted the sync branch June 7, 2022 21:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug::Library A bug in the library Improvement Something that is already implemented but can be done better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant