Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

feat: expose Application attrs for App Discovery #476

Merged
merged 4 commits into from
May 13, 2022
Merged

feat: expose Application attrs for App Discovery #476

merged 4 commits into from
May 13, 2022

Conversation

i0bs
Copy link
Contributor

@i0bs i0bs commented May 11, 2022

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

This simply exposes the tags and custom_install_url fields which were recently amended to the Application object when application discovery was announced. These also may have just been simply overlooked as well.

Side note: I've commented out another attribute missing, install_params which needs an object suited for it. I'm willing to implement said object for this PR if one desires

Changes

  • Added tags optional attribute for a list of string values
  • Added custom_install_url optional attribute for a string value

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@i0bs i0bs changed the base branch from naff to dev May 11, 2022 04:16
This simply exposes the `tags`, `install_params` and `custom_install_url` which were recently amended to the `Application` object when application discovery was announced. These also may have just been simply overlooked
@i0bs i0bs changed the base branch from dev to naff May 11, 2022 04:16
@i0bs
Copy link
Contributor Author

i0bs commented May 11, 2022

It also seems that there's a merge conflict for this file only when switching to naff branch too, FYI. No issues on dev branch if targeted.

@LordOfPolls
Copy link
Member

Set install_params as a dict for now. The to-do to create the object stands. Better to at least leave the data accessible than discard it

@LordOfPolls LordOfPolls merged commit 6f09f3b into NAFTeam:naff May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants