This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
feat: expose Application
attrs for App Discovery
#476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
This simply exposes the
tags
andcustom_install_url
fields which were recently amended to theApplication
object when application discovery was announced. These also may have just been simply overlooked as well.Side note: I've commented out another attribute missing,
install_params
which needs an object suited for it. I'm willing to implement said object for this PR if one desiresChanges
tags
optional attribute for a list of string valuescustom_install_url
optional attribute for a string valueChecklist
Python 3.10.x