Execute sequenced certs serially in execution driver #5788
Conversation
| @@ -1622,11 +1626,24 @@ impl AuthorityState { | |||
| &self, | |||
There was a problem hiding this comment.
nit: rename this function to add_pending_certificates_from_gossip? Not sure where else this is called.
There was a problem hiding this comment.
it is called in authority_server as well - if we can't execute a cert received via handle_certificate, we enqueue it there for causal completion.
There was a problem hiding this comment.
Btw, why did we have to enqueue the failed certificate in authority server? Just to avoid lagging behind?
| @@ -112,31 +113,67 @@ where | |||
| true | |||
| } | |||
| }) | |||
| .collect(); | |||
| .partition(|(_, (is_sequenced, _))| *is_sequenced); | |||
|
|
|||
There was a problem hiding this comment.
Could we add a debug logging here to print the number on each side of the partition?
| .into_iter() | ||
| .filter(|(idx, digest)| { | ||
| .filter(|(idx, (_, digest))| { |
There was a problem hiding this comment.
I think here we need to favor digests that are sequenced, if there is duplicate.
There was a problem hiding this comment.
correct, we first serially execute all sequenced digests.
mystenmark
force-pushed
the
mlogan-dumb-scheduler
branch
from
66b0562 to
387c421
Compare
mystenmark
force-pushed
the
mlogan-dumb-scheduler
branch
from
387c421 to
c5b6c51
Compare
* Execute sequenced certs serially in execution driver * Just use a bool to indicate whether sequenced * PR comments * Prioritize sequenced over unsequenced when there are duplicates
* Execute sequenced certs serially in execution driver * Just use a bool to indicate whether sequenced * PR comments * Prioritize sequenced over unsequenced when there are duplicates
Temporary work around (until the scheduler is finished) for degenerate behavior when there are many pending certs on the same object.