add AuthorityAggregatorBuilder #5233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadhansood
reviewed
Oct 17, 2022
sadhansood
approved these changes
Oct 17, 2022
longbowlu
force-pushed
the
stress-use-genesis-blob
branch
from
b29ec03 to
73fe833
Compare
ebmifa
pushed a commit
that referenced
this pull request
Oct 19, 2022
* use genesis.blob to set up remote bench * add AuthorityAggregatorBuilder
longbowlu
commented
Oct 19, 2022
Comment on lines
-280
to
-281
| send_timeout: Duration::from_secs(4), | ||
| recv_timeout: Duration::from_secs(4), |
There was a problem hiding this comment.
If there is no clue for why this is causing more timeout errors, let's just try setting this to 30s.
Comment on lines
-295
to
-296
| gateway_config.send_timeout, | ||
| gateway_config.recv_timeout, |
andll
pushed a commit
that referenced
this pull request
Oct 19, 2022
fff This reverts commit d863344.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
AuthorityAggregatorBuildertest_authority_aggregators and similar codes withAuthorityAggregatorBuildergenesis.blobinstead ofgateway.yaml, to cut dependencies on gateway related stuff.Note that with this change, the local bench no longer stores anything to disk, unlike before it persists the
gateway.yaml