Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "make sui CLI log file gated by env flag (#12095)" #12363

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

amnn
Copy link
Contributor

@amnn amnn commented Jun 6, 2023

Description

This reverts commit 8ff1005.

Following the previous fix, logs were showing up in terminal output even when RUST_LOG was not enabled.

Test Plan

sui$ cargo build --bin sui
sui$ ./target/debug/sui client active-address
sui/crates/sui$ cargo nextest run 

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

Revert behaviour where log output was controlled by an env flag, because when it was gated off, logs started showing up in command-line output. CLI now behaves as it did before: Producing a log file in the current working directory, but not displaying logs in line under normal operation.

@amnn amnn requested review from lxfind, sblackshear, damirka and oxade June 6, 2023 12:09
@amnn amnn self-assigned this Jun 6, 2023
@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
offline-signer-helper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 0:10am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Jun 6, 2023 0:10am
explorer-storybook ⬜️ Ignored (Inspect) Jun 6, 2023 0:10am
sui-wallet-kit ⬜️ Ignored (Inspect) Jun 6, 2023 0:10am
wallet-adapter ⬜️ Ignored (Inspect) Jun 6, 2023 0:10am

@amnn amnn merged commit 49657dd into main Jun 6, 2023
@amnn amnn deleted the amnn/revert-12095 branch June 6, 2023 15:32
Copy link

@dustin6341 dustin6341 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crates/sui/src/main.rs

Copy link

@dustin6341 dustin6341 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crates/sui/src/main.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants