add checkpoint low watermark for state sync #12231
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
longbowlu
requested review from
aschran,
bmwill,
phoenix-o,
mystenmark and
williampsmith
| @@ -138,6 +141,9 @@ struct PeerStateSyncInfo { | |||
| on_same_chain_as_us: bool, | |||
| /// Highest checkpoint sequence number we know of for this Peer. | |||
| height: CheckpointSequenceNumber, | |||
| /// lowest available checkpoint watermark for this Peer. | |||
| /// This defaults to 0 for now. | |||
There was a problem hiding this comment.
how does it work with defaulting to zero, once everyone has upgraded? will this ever cause us to request checkpoints from a peer that they might not have?
There was a problem hiding this comment.
Today we construct PeerStateSyncInfo only when for the first time we talk to this peer, by querying the genesis checkpoint summary. Later in every tick we poll peers to get their latest checkpoint availability (added in this PR). Theoretically it's possible to request a checkpoint before that info is updated.
I think we should call get_checkpoint_availability to init PeerStateSyncInfo once this call is rolled out so we always have the correct data. And before that happens we need to bear with the small possibility of what you described.
There was a problem hiding this comment.
Maybe add a todo for this? But I guess it's a non issue until peers start pruning tx, is that right?
longbowlu
force-pushed
the
low-checkpoint-watermark
branch
from
43f2d9c to
42c0eb8
Compare
longbowlu
force-pushed
the
low-checkpoint-watermark
branch
from
42c0eb8 to
f9ab0af
Compare
longbowlu
force-pushed
the
low-checkpoint-watermark
branch
from
f9ab0af to
bfd0b61
Compare
## Description Release Notes PR checker and generator ## Test Plan ``` eugene@mac-studio ~/code/sui (eugene/create_release_notes_workflow) $ ./scripts/generate-release-notes.sh releases/sui-v1.3.0-release releases/sui-v1.2.0-release #12359: #12444: Introduce new modules: `clob_v2` and `custodian_v2` and deprecate `clob` and `custodian`. #12231: Adds the checkpoint low watermark for state sync. This lets a node to know who to query checkpoint contents according to the watermarks, once checkpoint pruning is enabled. #12321: #12251: #12092: Added a version of stake withdraw function that returns the withdrawn SUI tokens, for better composability. #12258: #12171: update anemo to MystenLabs/anemo@1bfa784 which includes the `alternate_server_name` change. Set primary server name as `sui-{chain-id}`. Note that if node starts to run this version in testnet/mainnet before the update is officially rolled out, it's likely the node won't be able to state sync. #12043: - adds `sui::kiosk::default()` function for easy Kiosk setup ``` Will test the workflows once this PR lands
Description
This PR adds the checkpoint low watermark for state sync. This lets a node to know who to query checkpoint contents according to the watermarks, once checkpoint pruning is enabled.
get_peer_latest_checkpoint_info. This call will eventually replaceGetCheckpointSummaryRequest::Latestrequest and is called between every tick inget_latest_from_peer. The response include the highest synced checkpoint summary and the lowest available checkpoint content watermark.get_peer_latest_checkpoint_info, if it's 404 then we queryget_checkpoint_summaryand set the low watermark to 0 (if the node hasn't upgraded, they will have all the checkpoint content up to genesis).PeerHeights. When a node queries peer for checkpoint content, it will only contact peers who has low-watermark lower than the requested checkpoint.Test Plan
Tests in
state_sync/tests/rsIf your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes
Adds the checkpoint low watermark for state sync. This lets a node to know who to query checkpoint contents according to the watermarks, once checkpoint pruning is enabled.