[Deepbook] Add api for query market price #12088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Add api for query market price of the order book ## Test Plan cd to deepbook dir and run "sui move test" --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sblackshear
approved these changes
May 21, 2023
| ): (u64, u64){ | ||
| let (bid_price, _) = critbit::max_leaf(&pool.bids); | ||
| let (ask_price, _) = critbit::min_leaf(&pool.asks); | ||
| return (bid_price, ask_price) |
There was a problem hiding this comment.
Suggested change
| return (bid_price, ask_price) | |
| (bid_price, ask_price) |
amnn
added a commit
that referenced
this pull request
May 22, 2023
To fix protocol config snapshot test which is (correctly) complaining that the framework bytes being packaged in the binary no longer matches the snapshot for the max protocol version, after #12088. Test Plan: ``` cargo nextest run -- check_framework_change_with_protocol_upgrade ```
amnn
added a commit
that referenced
this pull request
May 22, 2023
## Description To fix protocol config snapshot test which is (correctly) complaining that the framework bytes being packaged in the binary no longer matches the snapshot for the max protocol version, after #12088. ## Test Plan ``` cargo nextest run -- check_framework_change_with_protocol_upgrade ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add api for query market price of the order book
Test Plan
cd to deepbook dir and run "sui move test"
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Description
Describe the changes or additions included in this PR.
Test Plan
How did you test the new or updated feature?
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes