Faucet v2

[stefan-mysten]

This PR updates the codebase to use the new v2 faucet APIs.

[bmwill]

I don't think this lifetime is correct as value borrowed wouldn't live long enough. probably more correct to make this 'static

[stefan-mysten]

Clippy complains when making this static, here (and in all subsequent helper_setup calls)

sui-rust-sdk/crates/sui-transaction-builder/src/lib.rs

Line 854 in e4d01b4

let (address, pk, coins) = helper_setup(&mut tx, &client).await;

[bmwill]

whats the error you're seeing?

[stefan-mysten]

If I make Vec<Coin<'static>>, then we get this -- note that compiling is fine, but clippy is unhappy

error: lifetime may not live long enough
   --> crates/sui-transaction-builder/src/lib.rs:602:9
    |
570 |     async fn helper_setup<'a>(
    |                           -- lifetime `'a` defined here
...
602 |         (address, pk, coins.to_vec())
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ returning this value requires that `'a` must outlive `'static`

[stefan-mysten]

Note, that I am still pretty unfamiliar with lifetime annotations and don't really understand what's going on in this case.

If I remove the <'a> lifetime annotation from the function and replace it like this:

    async fn helper_setup(
        tx: &mut TransactionBuilder,
        client: &'static Client,
    ) -> (Address, Ed25519PrivateKey, Vec<Coin<'static>>) {

then building fails, which is fair because all those tests create a local client object.

672 |         let client = Client::new_localhost();
   |             ------ binding `client` declared here
673 |         let (_, pk, coins) = helper_setup(&mut tx, &client).await;
   |                              ----------------------^^^^^^^-
   |                              |                     |
   |                              |                     borrowed value does not live long enough
   |                              argument requires that `client` is borrowed for `'static`
   ```