Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implicitly focus entry on no focus request sent #262

Merged
merged 2 commits into from
May 8, 2024

Conversation

Myriad-Dreamin
Copy link
Owner

After opening the file it doesn't show the error unless I save the file (no-op).

vscode invokes lsp's focus command but neovim doesn't. should add an issue, and discuss a suitable behavior to change focus file if the client is neovim.

It is nice if client focus entry explicitly, however neovim/helix/zed clients don't do that. Adding many activity hooks to track activating document status if a client is not performing any focus command request.

We do want to focus the file implicitly by textDocument/diagnostic (pullDiagnostics mode), as suggested by language-server-protocol#718, however, this has poor support, e.g. since neovim 0.10.0.

See microsoft/language-server-protocol#718

@Myriad-Dreamin Myriad-Dreamin changed the title feat: implicitly focus entry on no focus command sent feat: implicitly focus entry on no focus request sent May 8, 2024
@Myriad-Dreamin Myriad-Dreamin merged commit d05c501 into main May 8, 2024
13 checks passed
@Myriad-Dreamin Myriad-Dreamin deleted the implicit-focus-entry branch May 8, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant