Merge: Shortcode search #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- shortcodes should now be inserted into the shortcodes column
See convo starting at Ulauncher#9 (comment) for details
See Ulauncher#9 (comment) for details.
Also added some nice comments, and Implemented a bit of A.2. See the following thread for details: Ulauncher#9 (comment)
This bug seems like it might have been present since I first updated this with the EmojiSpider, since the page that it scrapes from doesn't even list modifier emojis anymore
skin tone modifiers should work perfectly now
I personally like the 'startswith :' approach better
This was referenced Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges shortcode search into master.
This resolves the skin tone selection bug, and adds shortcodes as a search option. See Ulauncher#9 and Ulauncher#8 for details.