src: don't check failure with ERR_peek_error()

It's possible there is already an existing error on OpenSSL's error stack that is unrelated to the EVP_DigestInit_ex() operation we just executed. Fixes: nodejs#4221 PR-URL: nodejs#4731 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
MylesBorins · Feb 15, 2016 · c41ed59 · c41ed59
1 parent 188cff3
commit c41ed59
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -3440,8 +3440,7 @@ bool Hash::HashInit(const char* hash_type) {
   if (md_ == nullptr)
     return false;
   EVP_MD_CTX_init(&mdctx_);
-  EVP_DigestInit_ex(&mdctx_, md_, nullptr);
-  if (0 != ERR_peek_error()) {
+  if (EVP_DigestInit_ex(&mdctx_, md_, nullptr) <= 0) {
     return false;
   }
   initialised_ = true;