Add POA.network #1365
Closed
Add POA.network #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
any idea why travis failed? What should I do? |
|
@rstormsf Looks like you had a failed test! https://travis-ci.org/MyCryptoHQ/MyCrypto/builds/356708499 We're actually already working on integrating POA in the PR found here: https://github.com/MyCryptoHQ/MyCrypto/pull/1259/files. Perhaps you could help us validate the implementation there? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1364
Description
Adding https://core.poa.network Chain id: 99, was already supported in MEW, mycrypto
EIP155 protected network
I filed an issue #1363 because I don't believe that other networks should suffer if Metamask team won't add some ETH-like network, doesn't mean the network doesn't work with metamask
MetaMask/metamask-extension#2815
Also, there are proposals on how it might actually work without having metamask to make political decisions.
MetaMask/metamask-extension#3604
But any network works with metamask by using Custom RPC port. The same way it did with MEW and mycrypto.com
I don't see why it shouldn't work in beta.mycrypto.com