jsonformatter adds extra "_JsonFormatter__extra" key to logs when using mix_extra=True

[akash10anand]

[MyColorfulDays]

@akash10anand Please paste a code example how to reproduce the problem

[akash10anand]

Log config

file_format = JsonFormatter(
        RECORD_CUSTOM_FORMAT,
        mix_extra=True,
        indent=4)
file_handler.setFormatter(file_format)

Output log in Log.log

{
    "Name": "main",
    "Levelname": "INFO",
    "Filename": "create_quiz.py",
    "Lineno": 28,
    "FuncName": "get_quiz_summary",
    "Asctime": "2020-12-31 20:10:41,375",
    "Message": "Got quiz summary",
    "code": 200,
    "body": {
        "credits_earned": 0,
        "quizzes_attempted": 11
    },
    "_JsonFormatter__extra": {
        "code": 200,
        "body": {
            "credits_earned": 0,
            "quizzes_attempted": 11
        }
    }
}

[MyColorfulDays]

@akash10anand
Is this you wanted?

test_20210101.py

#!/usr/bin/env python3.7

import logging

from jsonformatter import JsonFormatter


def get_extras(**attrs):
    extras = {
        k: attrs[k]
        for k in attrs
        if k not in {
            'name',
            'msg',
            'args',
            'levelname',
            'levelno',
            'pathname',
            'filename',
            'module',
            'exc_info',
            'exc_text',
            'stack_info',
            'lineno',
            'funcName',
            'created',
            'msecs',
            'relativeCreated',
            'thread',
            'threadName',
            'processName',
            'process',
            'message',
            'asctime'
        }
    }
    return extras

formatter = JsonFormatter(
    fmt={
        "Name": "name",
        "Levelname": "levelname",
        "Filename": "filename",
        "Lineno": "lineno",
        "FuncName": "funcName",
        "Asctime": "asctime",
        "Message": "message",
        "_JsonFormatter__extra": "extras"  # make sure this custom attribute in the last of `fmt`
    },
    record_custom_attrs={
        "extras": get_extras
    },
    ensure_ascii=False,
    mix_extra=True,
    mix_extra_position='tail'  # optional: head, mix
)

sh = logging.StreamHandler()
sh.setFormatter(formatter)
sh.setLevel(logging.INFO)

root = logging.getLogger()
root.setLevel(logging.INFO)
root.addHandler(sh)

root.info('empty extra log')

root.info('Got quiz summary', extra={
    "code": 200,
    "body": {
        "credits_earned": 0,
        "quizzes_attempted": 11
    }
})

output

{"Name": "root", "Levelname": "INFO", "Filename": "test_20210101.py", "Lineno": 66, "FuncName": "<module>", "Asctime": "2021-01-01 00:10:50,726", "Message": "empty extra log", "_JsonFormatter__extra": {}}
{"Name": "root", "Levelname": "INFO", "Filename": "test_20210101.py", "Lineno": 72, "FuncName": "<module>", "Asctime": "2021-01-01 00:10:50,727", "Message": "Got quiz summary", "_JsonFormatter__extra": {"code": 200, "body": {"credits_earned": 0, "quizzes_attempted": 11}}, "code": 200, "body": {"credits_earned": 0, "quizzes_attempted": 11}}

[akash10anand]

No @MyColorfulDays
In my case, I don't want the "_JsonFormatter__extra" in the log since the extra keys are already mixed, so no point having them 2nd time.
But it automatically coming

[MyColorfulDays]

@akash10anand
Emmm, I'm confused.
Through the issue title I think you want _JsonFormatter__extra in log when using mix_extra=True, but the reply that you don't want the _JsonFormatter__extra in the log since the extra keys are already mixed.
Can you paste a complete code example or a pseudo-code, include the output?

No @MyColorfulDays
In my case, I don't want the "_JsonFormatter__extra" in the log since the extra keys are already mixed, so no point having them 2nd time.
But it automatically coming

[akash10anand]

@MyColorfulDays No no, I don't want _JsonFormatter__extra to come in my log. But it is coming automatically.

[MyColorfulDays]

@akash10anand Oh, I see. But this shouldn't happen.
Which version do you use？
Can you supply a minimum reproduce code example? Let me see whether it's a bug or not.

[akash10anand]

@MyColorfulDays I am using version 0.3.0

I am using:

RECORD_CUSTOM_FORMAT = '''{
    "Name":            "name",
    "Levelname":       "levelname",
    "Filename":        "filename",
    "Lineno":          "lineno",
    "FuncName":        "funcName",
    "Asctime":         "asctime",
    "Message":         "message"
}'''

file_handler = logging.FileHandler(filename=LOG_FILE, mode='w')
file_format = JsonFormatter(
     RECORD_CUSTOM_FORMAT,
     mix_extra=True,
     indent=4)

log.info("some message", extra={'extra1': 'extra1'})

This puts an extra _JsonFormatter__extra in the log automatically.

[MyColorfulDays]

@akash10anand This bug was fixed. Please use blow command to fix it.

$ pip install jsonformatter --upgrade

or

$ git clone https://github.com/MyColorfulDays/jsonformatter.git
$ cd jsonformatter
$ python setup.py install