Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a playground page to test whether MvxContentViews load their view models #2683

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Add a playground page to test whether MvxContentViews load their view models #2683

merged 1 commit into from
Mar 14, 2018

Conversation

jessewdouglas
Copy link
Contributor

@jessewdouglas jessewdouglas commented Mar 13, 2018

@martijn00 Here is the PR you requested to test whether MvxContentViews automatically load and initialize their view models. Based on this, they don't appear to do so. Please let me know if I'm doing something wrong.

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Adds a page to the playground to test whether content views automatically load and initialize their corresponding view model.

⤵️ What is the current behavior?

The test page doesn't exist in the playground.

🆕 What is the new behavior (if this is a feature change)?

The test page is available in the playground.

💥 Does this PR introduce a breaking change?

No.

🐛 Recommendations for testing

Launch the Playground.Forms.* project. On the root page, under "Forms views," tap "Show Content View." The content view page contains two labels, one with static text that reads "Static Text," the other with bound text that should read "Bound Text." Confirm whether both labels' text appears properly, or just the static text. (For me, I only see "Static Text", not "Bound Text".

📝 Links to relevant issues/docs

🤔 Checklist before submitting

@dnfclas
Copy link

dnfclas commented Mar 13, 2018

CLA assistant check
All CLA requirements met.

@martijn00 martijn00 added this to the 6.0.0 milestone Mar 14, 2018
@martijn00 martijn00 merged commit 78dec7b into MvvmCross:develop Mar 14, 2018
@nmilcoff nmilcoff added the p/samples Samples platform label Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p/samples Samples platform
Development

Successfully merging this pull request may close these issues.

4 participants