New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Forms namespaces to match traditional Xamarin #2612

Merged

martijn00 merged 1 commit into MvvmCross:develop from DGenix:forms-namespaces

Feb 12, 2018

Contributor

nmilcoff commented Feb 12, 2018

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Code improvement

⤵️ What is the current behavior?

In MvvmCross.Forms, ViewPresenter code is inside Views
The folder containing base Views is called EventSource

🆕 What is the new behavior (if this is a feature change)?

ViewPresenter code is inside Presenters
Folder & namespaces renamed to Base

💥 Does this PR introduce a breaking change?

Yes

🐛 Recommendations for testing

Build the solution

📝 Links to relevant issues/docs

Previous PR: #2606

🤔 Checklist before submitting

All projects build
Follows style guide lines (code style guide)
Relevant documentation was updated (docs style guide)
Rebased onto current develop


          Update forms namespaces to match traditional Xamarin and usages

95287c0

nmilcoff added the Code improvement label

nmilcoff added this to the 6.0.0 milestone

martijn00 approved these changes

View reviewed changes

martijn00 merged commit acf2472 into MvvmCross:develop

nmilcoff deleted the forms-namespaces branch

February 19, 2018 23:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet