Fix native pages not loading without attribute #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| using MvvmCross.Forms.Platform; | ||
|
|
||
| namespace MvvmCross.Forms.Views | ||
| { | ||
| public interface IMvxFormsViewPresenter | ||
| public interface IMvxFormsViewPresenter : IMvxAttributeViewPresenter |
There was a problem hiding this comment.
Is the name "IMvxFormsViewPresenter" too close to "IMvxFormsPagePresenter"? Perhaps something like "IMvxFormsNativeViewPresenter" or "IMvxFormsPlatformViewPresenter" or inline with Forms naming "IMvxFormsOnPlatformViewPresenter"
There was a problem hiding this comment.
We already have this interface and it is implement on all platforms. So not to break the naming i kept it the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
This fixes the work from #2496 in a more generic way.
🆕 What is the new behavior (if this is a feature change)?
💥 Does this PR introduce a breaking change?
Yes
🐛 Recommendations for testing
📝 Links to relevant issues/docs
#2496
🤔 Checklist before submitting