Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MvxAndroidViewsContainer: Remove NewTask flag as default #2516

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

nmilcoff
Copy link
Contributor

@nmilcoff nmilcoff commented Jan 7, 2018

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Code improvement

⤵️ What is the current behavior?

Each time a new Activity is launched on Android, by default the flag NewTask is added.

🆕 What is the new behavior (if this is a feature change)?

The behaviour described above is fixed.

As @davidschwegler commented on the original issue:

NewTask is generally only used in rare cases where the calling app wants to switch to a completely different activity task (eg a different app's activity stack), rather than placing the called activity on top of your own stack.

💥 Does this PR introduce a breaking change?

Probably no, but we need to communicate this in the release blog.

🐛 Recommendations for testing

/

📝 Links to relevant issues/docs

Closes #962

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated (docs style guide)
  • Nuspec files were updated (when applicable)
  • Rebased onto current develop

@nmilcoff nmilcoff added this to the 6.0.0 milestone Jan 7, 2018
@martijn00 martijn00 merged commit 4bad126 into MvvmCross:develop Jan 8, 2018
@nmilcoff nmilcoff deleted the no-more-new-task branch January 10, 2018 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p/android Android platform
Development

Successfully merging this pull request may close these issues.

Q: Why does MvxAndroidViewsContainer force ActivityFlags.NewTask?
2 participants