-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making it easier to override default IMvxViewModelTypeFinder implementation #2498
Making it easier to override default IMvxViewModelTypeFinder implementation #2498
Conversation
I'm not sure this is a good idea, every sort of view in MvvmCross is Mvx based. This is so we can internally make changes to fix bugs. If we are supporting non mvx views it might even get harder for us to keep up to date with external changes. What's wrong with leaving it as is? |
There's just too much friction involved in getting started with MVX with Forms. |
If anything is difficult to override or if anything fails, we should just fix it / improve it / document it. But other than that I think MvvmCross has always been more of a full framework than something you can just plug in in an app. I'd say that discussion should be moved into a separate issue. |
6bc8972
to
71b3dca
Compare
@martijn00 @nmilcoff I've reverted the changes concerning MvxApplication and MvxContentPage, leaving on the change that makes it easier to override the default finder. |
…use Application instead
…r implement IMvxView.
74a0712
to
76f0e74
Compare
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Feature
Currently in order to override the implementation of IMvxViewModelTypeFinder you have to override the entire InitializeViewModelTypeFinder method in each setup for your solution
🆕 What is the new behavior (if this is a feature change)?
Can now simply override CreateViewModelByNameLookup, CreateViewModelByNameRegistry or RegisterViewTypeFinder to change the lookup, registry or finder
💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
📝 Links to relevant issues/docs
N/A
🤔 Checklist before submitting