MvxRecyclerViewAdapter: Support worker threads #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmilcoff
added
p/android-support
|
@softlion can you maybe review this PR? 🙂 |
martijn00
reviewed
Dec 19, 2017
| @@ -241,7 +243,15 @@ protected virtual void SetItemsSource(IEnumerable value) | |||
|
|
|||
| protected virtual void OnItemsSourceCollectionChanged(object sender, NotifyCollectionChangedEventArgs e) | |||
| { | |||
| NotifyDataSetChanged(e); | |||
| if (Looper.MainLooper == Looper.MyLooper()) | |||
There was a problem hiding this comment.
Isn't there a Mvx method that checks the thread and runs it on main if necessary?
There was a problem hiding this comment.
There is MvxAndroidMainThreadDispatcher. However this class can't inherit from MvxMainThreadDispatchingObject. So this is a good solution.
This comment was marked as abuse.
This comment was marked as abuse.
Cheesebaron
approved these changes
Dec 19, 2017
| @@ -241,7 +243,15 @@ protected virtual void SetItemsSource(IEnumerable value) | |||
|
|
|||
| protected virtual void OnItemsSourceCollectionChanged(object sender, NotifyCollectionChangedEventArgs e) | |||
| { | |||
| NotifyDataSetChanged(e); | |||
| if (Looper.MainLooper == Looper.MyLooper()) | |||
There was a problem hiding this comment.
There is MvxAndroidMainThreadDispatcher. However this class can't inherit from MvxMainThreadDispatchingObject. So this is a good solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Code improvement
When a user tries to update a bound ItemsSource collection from a worker thread, MvxRecyclerViewAdapter just 💥💥.
🆕 What is the new behavior (if this is a feature change)?
MvxRecyclerViewAdapter handles collection changes from worker threads.
💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
Run TestProjects/Android-Support.
ExampleRecyclerViewModelupdates a collection from background.📝 Links to relevant issues/docs
Closes #2144
🤔 Checklist before submitting