Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MvxNavigationServiceAppStart: Don't swallow exceptions #2471

Merged
merged 1 commit into from
Jan 1, 2018

Conversation

nmilcoff
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

MvxNavigationServiceAppStart does not throw exceptions inside Navigate.

🆕 What is the new behavior (if this is a feature change)?

Exceptions are thrown.

💥 Does this PR introduce a breaking change?

No.

🐛 Recommendations for testing

  1. Set Playground.Mac as starter project
  2. Introduce an Interface like IMyService
  3. Inject IMyService in Playground.Core -> RootViewModel
  4. Run the app.

📝 Links to relevant issues/docs

Fixes: #2447

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated (docs style guide)
  • Nuspec files were updated (when applicable)
  • Rebased onto current develop

@nmilcoff nmilcoff added the t/bug Bug type label Dec 17, 2017
@nmilcoff
Copy link
Contributor Author

Sorry about that async void, but if we don't await the Navigate call, the exception is not catched.

Maybe someone has a better idea on how to do this?

@martijn00 martijn00 added this to the 6.0.0 milestone Dec 20, 2017
@martijn00 martijn00 merged commit 20b5bd9 into MvvmCross:develop Jan 1, 2018
@nmilcoff nmilcoff deleted the nav-appstart branch January 10, 2018 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t/bug Bug type
Development

Successfully merging this pull request may close these issues.

RegisterNavigationServiceAppStart vs RegisterAppStart
2 participants