Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite loop in modal when having an open modal #2457

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Fix infinite loop in modal when having an open modal #2457

merged 1 commit into from
Dec 11, 2017

Conversation

martijn00
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

App crashes when having a modal

🆕 What is the new behavior (if this is a feature change)?

Not crashing

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Run the playground

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated (docs style guide)
  • Nuspec files were updated (when applicable)
  • Rebased onto current develop

@martijn00 martijn00 added this to the 5.6.1 milestone Dec 11, 2017
@martijn00 martijn00 merged commit c4a57cd into MvvmCross:develop Dec 11, 2017
@martijn00 martijn00 mentioned this pull request Dec 11, 2017
Closed
5 tasks
@martijn00 martijn00 deleted the forms-modal branch December 11, 2017 15:55
@nmilcoff nmilcoff mentioned this pull request Dec 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickrandolph nickrandolph nickrandolph approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
5.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@martijn00 @nickrandolph