Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue where icon disappears when navigating within master deta… #2429

Merged
merged 1 commit into from
Dec 1, 2017

Conversation

nickrandolph
Copy link
Contributor

Fixing issue on iOS where master detail icon disappears on navigation

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

On navigation to page with NoHistory=true, icon disappears

🆕 What is the new behavior (if this is a feature change)?

Icon doesn't disappear

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

In playground set one of the details pages to NoHistory=true in attribute
Run playground and navigate

📝 Links to relevant issues/docs

#2427

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated (docs style guide)
  • Nuspec files were updated (when applicable)
  • [X ] Rebased onto current develop

@martijn00 martijn00 merged commit 8f81487 into MvvmCross:develop Dec 1, 2017
@martijn00 martijn00 added this to the 5.6.0 milestone Dec 3, 2017
@nickrandolph nickrandolph deleted the ios-masterdetail-navissue branch January 13, 2018 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants