Make no history work with nested stacks #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How to test this? Which cases does it fix? |
|
Updated description. |
|
On Forms.iOS. If I set |
|
@Cheesebaron You've got to set |
Cheesebaron
requested changes
Nov 3, 2017
| @@ -172,8 +172,9 @@ public virtual void RegisterAttributeTypes(Dictionary<Type, MvxPresentationAttri | |||
| if (attribute.WrapInNavigationPage && FormsApplication.MainPage is MvxNavigationPage currentPage) | |||
| { | |||
| if (attribute.NoHistory) | |||
There was a problem hiding this comment.
This if pattern seems duplicated a lot of places in this class. Can we encapsulate this please?
Cheesebaron
approved these changes
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Fixes replacing root not working in a lot of situations.
The current navigation root is not replaced.
🆕 What is the new behavior (if this is a feature change)?
It is now correctly replaced.
💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
Set
NoHistory = truein one of the pages and run the playground sample.📝 Links to relevant issues/docs
Fixes #2320
🤔 Checklist before submitting