Fix Xamarin-Sidebar initialization #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijn00
previously approved these changes
Oct 30, 2017
Cheesebaron
previously requested changes
Oct 30, 2017
| @@ -111,7 +111,7 @@ protected virtual bool ShowPanelAndResetToRoot(MvxSidebarPresentationAttribute a | |||
|
|
|||
| protected virtual bool ShowPanel(MvxSidebarPresentationAttribute attribute, UIViewController viewController) | |||
| { | |||
| var navigationController = (SideBarViewController as MvxSidebarViewController).NavigationController; | |||
| var navigationController = (SideBarViewController).NavigationController; | |||
There was a problem hiding this comment.
Nice catch, thanks!
…rywhere, don't joke around using interfaces
nmilcoff
force-pushed
the
fix-sidebar-first-nav
branch
from
c865463
to
d323a55
Compare
martijn00
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix / Code improvement.
Sidebar Menu is not always initialized and menu icons are not displayed.
On the other side, the Sidebar Presenter had a property of type
IMvxSidebarViewControllerbut the only way it could work was if it was actually aMvxSidebarViewController.🆕 What is the new behavior (if this is a feature change)?
Above is fixed and the property type is changed to
MvxSidebarViewController.💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
📝 Links to relevant issues/docs
Closes #2188
Closes #2247
Could be related to #2268
🤔 Checklist before submitting