New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pp file for WPF StarterPack nuspec. Update doc. #2141

Merged

martijn00 merged 2 commits into MvvmCross:develop from jz5:nuspec

Aug 25, 2017

Contributor

jz5 commented Aug 25, 2017

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

pp files update
doc update

⤵️ What is the current behavior?

Used simple WPF presenter in pp files
Written old StarterPack codes in MvvmCross Overview doc

🆕 What is the new behavior (if this is a feature change)?

Use new WPF presenter in pp files
Update MvvmCross Overview doc
- Use latest StarterPack codes.
- But this doc is too old. Old descriptions are remain.

💥 Does this PR introduce a breaking change?

Yes. pp files are for 5.2

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

All projects build
Follows style guide lines (code style guide)
Relevant documentation was updated (docs style guide)
Nuspec files were updated (when applicable)
Rebased onto current develop

jz5 added 2 commits

August 25, 2017 17:56


          Use default presenter

bbdddc8


          📝 Update to StarterPack codes. Fix acronyms.

4b91703

martijn00 added this to the 5.2.0 milestone

martijn00 approved these changes

View reviewed changes

martijn00 merged commit 33c35c8 into MvvmCross:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet