MvxIosViewPresenter: Fix ShowRootViewController #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or null values in ViewControllers prop
…tire stack of navigation in a Tab
|
@nmilcoff, thanks for your PR! By analyzing the history of the files in this pull request, we identified @slodge, @mvanbeusekom and @g0rdan to be potential reviewers. |
…efore releasing ViewControllers of MasterNavigationController
| @@ -424,7 +445,7 @@ protected virtual void SetWindowRootViewController(UIViewController controller) | |||
| foreach (var v in _window.Subviews) | |||
| v.RemoveFromSuperview(); | |||
|
|
|||
| _window.AddSubview(controller.View); | |||
| //_window.AddSubview(controller.View); | |||
| _window.RootViewController = controller; | |||
There was a problem hiding this comment.
I think it is good practise not to leave commented out code in the code base. Just remove it, or if there is a good reason to leave it mention it with a comment in the code so other people also know why it is commented out.
There was a problem hiding this comment.
Definitely right @mvanbeusekom! Good spot, forgot to remove it before commiting
mvanbeusekom
approved these changes
Jul 30, 2017
martijn00
approved these changes
Jul 31, 2017
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix & improvements
#2076 introduced a refactor of ShowRootViewController method that broke the logic in some scenarios. Reason for this is that some properties of the ViewPresenter were being assigned too late (like TabBarViewController property, which caused #2084).
🆕 What is the new behavior (if this is a feature change)?
The logic was reverted without loosing the feature introduced in #2076. Also improved some other parts:
MvxTabBarController.ShowChildViewnow usesasoperator instead of a direct cast (app could potentially crash because of that)💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
Run Playground.iOS
📝 Links to relevant issues/docs
Related PR: #2076.
Related issue: #2084
🤔 Checklist before submitting