Fix crash when composing email without attachments #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ilber, thanks for your PR! By analyzing the history of the files in this pull request, we identified @slodge, @Cheesebaron and @martijn00 to be potential reviewers. |
Cheesebaron
approved these changes
Jun 27, 2017
martijn00
approved these changes
Jun 27, 2017
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce?
This is a bug fix of a crash that happens when you compose an email without giving the attachments parameter.
If you call the compose email without attachments, on ProcessMvxIntentResult of the MvxComposeEmailTask (Android) the app will crash.
🆕 What is the new behaviour (if this is a feature change)?
No crash doing the same action.
💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
Nothing.
📝 Links to relevant issues/docs
🤔 Checklist before submitting