Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show federation expiration metadata #1129

Merged
merged 3 commits into from
May 9, 2024
Merged

Conversation

futurepaul
Copy link
Collaborator

for #1128

here's what I have so far. putting this here so @TonyGiorgio can see the logic I used to get the metadata

Screenshot 2024-05-07 at 10 22 03 AM

@TonyGiorgio
Copy link
Collaborator

Okay thanks, want me to go ahead and get this all into mutiny-node?

@TonyGiorgio
Copy link
Collaborator

Try this: MutinyWallet/mutiny-node#1169

Copy link

cloudflare-workers-and-pages bot commented May 8, 2024

Deploying mutiny-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: b93dcde
Status: ✅  Deploy successful!
Preview URL: https://07c4e91b.mutiny-web.pages.dev
Branch Preview URL: https://show-expiration-warnings.mutiny-web.pages.dev

View logs

@TonyGiorgio
Copy link
Collaborator

  1. It's not obvious what I'm supposed to do after the "Manage Federations" pop up window comes up. I think if the "transfer funds" button stayed on the federation page no matter what, it would be more obvious. A popup could come up, saying whether they want to swap to lightning or swap to a new federation and they should add one if they have it?

  2. When the federation is the 2nd one, the pop up doesn't happen.

@futurepaul
Copy link
Collaborator Author

needs MutinyWallet/mutiny-node#1169 and a new version of mutiny node

@futurepaul futurepaul force-pushed the show-expiration-warnings branch 2 times, most recently from 705804a to 0729fb4 Compare May 9, 2024 01:39
src/routes/Transfer.tsx Outdated Show resolved Hide resolved
src/routes/Transfer.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs retest

@futurepaul
Copy link
Collaborator Author

looks good now @TonyGiorgio

Copy link
Collaborator

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, just a nit that the federation name in the popup would be useful.

@futurepaul futurepaul merged commit cfce841 into master May 9, 2024
5 checks passed
@futurepaul futurepaul deleted the show-expiration-warnings branch May 9, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants