Fix duplicate payment when paying lightning address #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
fix-duplicate-payment
branch
from
1e6657c
to
120897d
Compare
TonyGiorgio
approved these changes
May 9, 2024
benthecarman
force-pushed
the
fix-duplicate-payment
branch
from
120897d
to
9cd459c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would occasionally see a payment appear twice in our payment history, this was the case because when we would save the privacy level of the payment. It would sometimes have a different timestamp than the one we persisted in the fedimint client, this is would happen because the
MutinyInvoicewe returned was not the one with the updated timestamp, we only updated the timestamp for thePaymentInfowe persisted