This repository was archived by the owner on Jan 5, 2021. It is now read-only.
build: fix version comparison for go1.10 and beyond#91
Closed
teutat3s wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Thanks, this is a real annoyance. 👍 |
5chdn
approved these changes
Apr 3, 2018
|
That's bizarre. I could swear I JUST posted exactly this. But apparently you did! Hahahah either way at least I know I'm not the kind of crazy that thinks this is an issue erroneously. |
etaletai13
reviewed
Apr 11, 2018
etaletai13
left a comment
etaletai13
left a comment
There was a problem hiding this comment.
Correct me if I'm mistaken here; but might this be a time we should bump the build version of go for the project? I mean we're all trying to do this little hack to get it to build on a more recent release of go anyway, right?
Collaborator
|
@5chdn Awesome, thanks so much. |
|
It still doesn't build on 1.10.1 without doing a sed s/1.7/1.10/g on build/ci.go |
Contributor
|
We're anyway planning to rebase stuff as part of #95, so lets take care of this there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build process stops without this commit when using latest Go Version (go1.10) on MacOS High Sierra. With this commit all works.