[REFACTOR] UTC 기준 시간 통일 - #190
Merged
Merged
Conversation
rkdehdrbs7885-oss
requested review from
kimyw1018,
on1yoneprivate,
ownue and
p1001q
August 10, 2026 12:56
6 tasks
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthrough애플리케이션의 날짜·시간 타입을 ChangesUTC 시간 마이그레이션
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 12
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/main/java/com/mr/domain/analysis/dto/res/AnalysisResultResponseDTO.java (1)
25-38: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win분석 응답의
InstantJSON 형식을 테스트로 고정하세요.현재
AnalysisControllerTest는 DTO를 만들고 mockMvc로 요청하지만playedAt,createdAt,completedAt,report.createdAt,report.updatedAt의 JSON value를 검증하지 않습니다. Jackson 기본 설정에서는Instant가 숫자 epoch로 직렬화될 수 있으므로, ISO-8601 문자열이 의도한 계약이라면 테스트에서jsonPath(...).value("...Z")또는JsonFormat같은 계약 고정 방식을 적용하세요.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/com/mr/domain/analysis/dto/res/AnalysisResultResponseDTO.java` around lines 25 - 38, 고정된 ISO-8601 문자열 형식이 모든 분석 응답의 Instant 필드에 적용되는지 검증하세요. AnalysisResultResponseDTO.java의 25-38행과 109-110행, AnalysisCreateResponseDTO.java의 8-18행, AnalysisStatusResponseDTO.java의 8-28행에 해당하는 playedAt, createdAt, completedAt 및 report.createdAt/updatedAt 필드를 AnalysisControllerTest의 jsonPath 검증으로 실제 “...Z” 값을 확인하고, 필요하면 JsonFormat 등으로 직렬화 계약을 명시하세요.src/test/java/com/mr/domain/analysis/service/AnalysisStateServiceTest.java (1)
44-48: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win
PROCESSING_STARTED_AT와FIXED_CLOCK의 시각을 동일하게 맞추세요.
FIXED_CLOCK는2026-07-31T03:00:00Z를 반환하지만PROCESSING_STARTED_AT는2026-07-31T12:00:00Z입니다. 제공된AnalysisStateService.java의now()(Line 202-204)는Instant.now(clock)를 반환하므로 상태 전환에서 기록하는 시각과 검증 시각이 달라집니다. 관련 테스트가 실패합니다.기존 값이
2026-07-31 12:00의Asia/Seoul시각을 의미했다면 UTC 값은2026-07-31T03:00:00Z입니다. 그렇지 않으면FIXED_CLOCK를12:00Z로 변경하세요.수정 예시
- private static final Instant PROCESSING_STARTED_AT = Instant.parse("2026-07-31T12:00:00Z"); + private static final Instant PROCESSING_STARTED_AT = Instant.parse("2026-07-31T03:00:00Z");🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/test/java/com/mr/domain/analysis/service/AnalysisStateServiceTest.java` around lines 44 - 48, AnalysisStateServiceTest의 PROCESSING_STARTED_AT과 FIXED_CLOCK이 동일한 순간을 가리키도록 수정하세요. 기존 Asia/Seoul 기준 2026-07-31 12:00 의도를 유지하려면 PROCESSING_STARTED_AT을 2026-07-31T03:00:00Z로 맞추고, 그렇지 않으면 FIXED_CLOCK을 12:00Z로 변경하세요.
🧹 Nitpick comments (2)
src/test/java/com/mr/domain/auth/service/AuthTransactionServiceTest.java (1)
91-91: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win갱신 토큰 만료 시각을 정확히 검증하세요.
Line 107의
any(Instant.class)는 잘못된 만료 시각이나 누락된 전달을 검출하지 못합니다. Line 91에서 고정된Instant를 변수로 저장하세요. 그런 다음updateRefreshToken에서 같은 값을eq로 검증하세요. 토큰 만료 시각은 인증 보안 계약입니다.권장 테스트 수정
- given(tokenProvider.getRefreshTokenExpiryTime()).willReturn(Instant.now().plus(7, ChronoUnit.DAYS)); + Instant refreshTokenExpiry = Instant.parse("2026-12-31T00:00:00Z"); + given(tokenProvider.getRefreshTokenExpiryTime()).willReturn(refreshTokenExpiry); ... - any(Instant.class), + org.mockito.ArgumentMatchers.eq(refreshTokenExpiry),Also applies to: 107-107
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/test/java/com/mr/domain/auth/service/AuthTransactionServiceTest.java` at line 91, AuthTransactionServiceTest에서 tokenProvider.getRefreshTokenExpiryTime()에 전달하는 Instant를 고정된 변수로 저장하고, updateRefreshToken 검증의 any(Instant.class)를 해당 변수에 대한 eq 검증으로 변경하세요. 이를 통해 갱신 토큰 만료 시각이 정확히 전달되는지 검증하고 기존 토큰 관련 검증은 유지하세요.src/test/java/com/mr/domain/analysis/service/AnalysisStateServiceTest.java (1)
103-105: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win고정 시간 테스트에서
Instant.now()를 사용하지 마세요.이 테스트는
FIXED_CLOCK를 선언했지만 cutoff를 시스템 시계에서 생성합니다. 처리 시작 시각과 cutoff의 관계는 유지되지만 테스트 데이터가 실행 시각에 따라 달라집니다.FIXED_CLOCK.instant()를 사용해 테스트를 재현 가능하게 만드세요.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/test/java/com/mr/domain/analysis/service/AnalysisStateServiceTest.java` around lines 103 - 105, Update the cutoff initialization in AnalysisStateServiceTest to use FIXED_CLOCK.instant() instead of Instant.now(). Keep the existing processing-start timestamp relationship by deriving it from the fixed cutoff.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/com/mr/domain/analysis/scheduler/AnalysisRecoveryScheduler.java`:
- Around line 54-62: Update AnalysisRecoverySchedulerTest to expect the
processing cutoff as 2026-07-31T02:58:00Z when the fixed clock is
2026-07-31T03:00:00Z and processingThreshold is two minutes; keep the scheduler
implementation unchanged.
In
`@src/main/java/com/mr/domain/backingtrack/dto/res/BackingTrackCreateResponseDTO.java`:
- Around line 13-16: Update the JsonFormat patterns for both createdAt and
updatedAt in BackingTrackCreateResponseDTO.java (lines 13-16) and
BackingTrackUpdateResponseDTO.java (lines 13-20) to append XXX, preserving UTC
serialization while including the timezone offset in the API response.
In `@src/main/java/com/mr/domain/home/dto/res/HomeResponseDTO.java`:
- Line 184: Update the OpenAPI description and example for the playedAt field in
HomeResponseDTO to represent its Instant value in UTC, including an explicit UTC
offset such as “Z”. Keep the documented timestamp format consistent with the
API’s UTC response contract.
In `@src/main/java/com/mr/domain/learning/dto/res/LearningResultResponseDTO.java`:
- Around line 26-27: Update the completedAt `@Schema` metadata in
LearningResultResponseDTO to use the UTC instant example 2026-07-07T15:30:00Z,
and set format to date-time if needed to keep the generated SpringDoc/OpenAPI
schema consistent.
In
`@src/main/java/com/mr/domain/statistics/service/StatisticsAggregationService.java`:
- Around line 95-97: StatisticsAggregationService must derive the weekly KST
date from the injected clock’s Instant rather than LocalDate.now(clock). Update
the weekStart calculation around lines 95-97 to use Instant.now(clock) converted
through the Asia/Seoul zone, and reuse that same weekStart at line 117 without
recalculating it.
In `@src/main/java/com/mr/domain/statistics/service/StatisticsService.java`:
- Around line 52-59: StatisticsService의 주 시작일 계산에서 시스템 시간 대신 주입된 clock을 사용하도록
수정하세요. Instant.now(clock)을 KST로 변환한 날짜를 기준으로 thisWeekStart를 계산하고, lastWeekStart
및 fourWeeksAgoStart의 기존 파생 로직은 유지하세요. 고정 시각 기준으로 StatisticsServiceTest의 저장소 기대값을
2026-07-26T15:00:00Z 주 경계에 맞게 갱신하세요.
In `@src/main/resources/application.yml`:
- Around line 9-22: Update the datasource migration configuration around flyway
and jpa so Flyway is enabled and deployment environments use schema validation
instead of automatic updates. Add a versioned migration for the
LocalDateTime-to-Instant change that converts existing timestamp columns to
timestamptz using the explicitly required source timezone, including correction
of existing data before enforcing the new schema.
- Around line 60-66: application.yml의 aws.s3 설정에 S3Properties.keyPrefix()가 기대하는
aws.s3.key-prefix 계약을 반영하세요. keyPrefix가 선택 사항이면 사용할 기본값을 해당 설정에 추가하고, 필수 값이면 누락을
방지하도록 설정 예시에 명시하세요. S3ObjectKeyGenerator.generate()가 이 값을 그대로 사용해 유효한 객체 키 접두사를
생성하도록 S3Properties와 설정 키의 이름 및 기본값을 일치시키세요.
In `@src/test/java/com/mr/domain/home/service/HomeServiceTest.java`:
- Around line 148-150: Update the date fixtures in HomeServiceTest methods
around the referenced scenarios to derive every today and yesterday value from
the Asia/Seoul timezone instead of LocalDate.now(). Preserve the existing
KST-midnight conversion and test data offsets while ensuring all attendance and
weekly-boundary fixtures use the same explicit zone.
In `@src/test/java/com/mr/domain/playing/service/PlayingServiceTest.java`:
- Around line 591-594: Update
PlayingService.publishPracticeMilestoneNotification to derive the Seoul local
date from the injected clock.instant() rather than LocalDate.now(kstZone), then
calculate the Monday week start from that date. Preserve the existing week-start
and repository lookup behavior while ensuring the test’s fixed Clock determines
the queried period.
In `@src/test/java/com/mr/domain/statistics/service/StatisticsServiceTest.java`:
- Around line 119-121: The expected UTC instants are constructed with an
incorrect Z offset. In
src/test/java/com/mr/domain/statistics/service/StatisticsServiceTest.java:119-121,
create the KST midnight instant using atStartOfDay(SERVICE_ZONE_ID).toInstant();
in
src/test/java/com/mr/domain/analysis/service/AnalysisRecoverySchedulerTest.java:84,
create the stale cutoff with FIXED_CLOCK.instant().minus(Duration.ofMinutes(2)).
In `@src/test/java/com/mr/domain/user/service/UserProfileServiceTest.java`:
- Line 232: Update the expired-subscription fixture in UserProfileServiceTest so
its end date is in the past, using one shared reference Instant and setting the
end to 10 days before it or 30 days after the start. Keep the existing start
date 40 days before the reference time.
---
Outside diff comments:
In `@src/main/java/com/mr/domain/analysis/dto/res/AnalysisResultResponseDTO.java`:
- Around line 25-38: 고정된 ISO-8601 문자열 형식이 모든 분석 응답의 Instant 필드에 적용되는지 검증하세요.
AnalysisResultResponseDTO.java의 25-38행과 109-110행,
AnalysisCreateResponseDTO.java의 8-18행, AnalysisStatusResponseDTO.java의 8-28행에
해당하는 playedAt, createdAt, completedAt 및 report.createdAt/updatedAt 필드를
AnalysisControllerTest의 jsonPath 검증으로 실제 “...Z” 값을 확인하고, 필요하면 JsonFormat 등으로 직렬화
계약을 명시하세요.
In `@src/test/java/com/mr/domain/analysis/service/AnalysisStateServiceTest.java`:
- Around line 44-48: AnalysisStateServiceTest의 PROCESSING_STARTED_AT과
FIXED_CLOCK이 동일한 순간을 가리키도록 수정하세요. 기존 Asia/Seoul 기준 2026-07-31 12:00 의도를 유지하려면
PROCESSING_STARTED_AT을 2026-07-31T03:00:00Z로 맞추고, 그렇지 않으면 FIXED_CLOCK을 12:00Z로
변경하세요.
---
Nitpick comments:
In `@src/test/java/com/mr/domain/analysis/service/AnalysisStateServiceTest.java`:
- Around line 103-105: Update the cutoff initialization in
AnalysisStateServiceTest to use FIXED_CLOCK.instant() instead of Instant.now().
Keep the existing processing-start timestamp relationship by deriving it from
the fixed cutoff.
In `@src/test/java/com/mr/domain/auth/service/AuthTransactionServiceTest.java`:
- Line 91: AuthTransactionServiceTest에서
tokenProvider.getRefreshTokenExpiryTime()에 전달하는 Instant를 고정된 변수로 저장하고,
updateRefreshToken 검증의 any(Instant.class)를 해당 변수에 대한 eq 검증으로 변경하세요. 이를 통해 갱신 토큰
만료 시각이 정확히 전달되는지 검증하고 기존 토큰 관련 검증은 유지하세요.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ae5c2413-b455-480d-bb5a-181c9f8f28df
📒 Files selected for processing (71)
src/main/java/com/mr/Application.javasrc/main/java/com/mr/domain/analysis/dto/res/AnalysisCreateResponseDTO.javasrc/main/java/com/mr/domain/analysis/dto/res/AnalysisResultResponseDTO.javasrc/main/java/com/mr/domain/analysis/dto/res/AnalysisStatusResponseDTO.javasrc/main/java/com/mr/domain/analysis/entity/Analysis.javasrc/main/java/com/mr/domain/analysis/model/AnalysisProcessingClaim.javasrc/main/java/com/mr/domain/analysis/repository/AnalysisRepository.javasrc/main/java/com/mr/domain/analysis/scheduler/AnalysisRecoveryScheduler.javasrc/main/java/com/mr/domain/analysis/service/AnalysisProcessingService.javasrc/main/java/com/mr/domain/analysis/service/AnalysisStateService.javasrc/main/java/com/mr/domain/auth/entity/SocialAuth.javasrc/main/java/com/mr/domain/auth/service/AuthTransactionService.javasrc/main/java/com/mr/domain/backingtrack/dto/res/BackingTrackCreateResponseDTO.javasrc/main/java/com/mr/domain/backingtrack/dto/res/BackingTrackUpdateResponseDTO.javasrc/main/java/com/mr/domain/backingtrack/repository/BackingTrackRepository.javasrc/main/java/com/mr/domain/backingtrack/service/BackingTrackService.javasrc/main/java/com/mr/domain/history/dto/res/HistoryDetailResponseDTO.javasrc/main/java/com/mr/domain/history/dto/res/HistoryListResponseDTO.javasrc/main/java/com/mr/domain/history/service/HistoryService.javasrc/main/java/com/mr/domain/home/dto/res/HomeResponseDTO.javasrc/main/java/com/mr/domain/home/service/HomeService.javasrc/main/java/com/mr/domain/learning/dto/res/LearningResultResponseDTO.javasrc/main/java/com/mr/domain/learning/entity/UserLearningProgress.javasrc/main/java/com/mr/domain/learning/service/LearningService.javasrc/main/java/com/mr/domain/mentor/dto/res/MentorMessageHistoryResponseDTO.javasrc/main/java/com/mr/domain/mentor/dto/res/MentorStreamEventDTO.javasrc/main/java/com/mr/domain/mentor/entity/MentorChatSession.javasrc/main/java/com/mr/domain/notification/dto/res/NotificationResponseDTO.javasrc/main/java/com/mr/domain/notification/repository/NotificationRepository.javasrc/main/java/com/mr/domain/notification/service/NotificationEventListener.javasrc/main/java/com/mr/domain/playing/dto/res/AnalysisContextResponse.javasrc/main/java/com/mr/domain/playing/dto/res/PlayingDeleteResponse.javasrc/main/java/com/mr/domain/playing/dto/res/PlayingDetailResponse.javasrc/main/java/com/mr/domain/playing/dto/res/PlayingStartResponse.javasrc/main/java/com/mr/domain/playing/entity/Playing.javasrc/main/java/com/mr/domain/playing/repository/PlayingRepository.javasrc/main/java/com/mr/domain/playing/service/PlayingService.javasrc/main/java/com/mr/domain/statistics/entity/UserStatistics.javasrc/main/java/com/mr/domain/statistics/service/StatisticsAggregationService.javasrc/main/java/com/mr/domain/statistics/service/StatisticsService.javasrc/main/java/com/mr/domain/subscriptions/entity/Subscription.javasrc/main/java/com/mr/domain/user/dto/res/UserProfileResponseDTO.javasrc/main/java/com/mr/domain/user/service/UserProfileService.javasrc/main/java/com/mr/domain/weakness/entity/WeaknessNote.javasrc/main/java/com/mr/global/entity/BaseCreatedDeletedEntity.javasrc/main/java/com/mr/global/entity/BaseCreatedEntity.javasrc/main/java/com/mr/global/entity/BaseTimeDeletedEntity.javasrc/main/java/com/mr/global/entity/BaseTimeEntity.javasrc/main/java/com/mr/global/file/s3/service/S3ObjectKeyGenerator.javasrc/main/java/com/mr/global/security/jwt/JwtTokenProvider.javasrc/main/java/com/mr/global/util/RelativeDateFormatter.javasrc/main/resources/application.ymlsrc/test/java/com/mr/domain/analysis/controller/AnalysisControllerTest.javasrc/test/java/com/mr/domain/analysis/entity/AnalysisTest.javasrc/test/java/com/mr/domain/analysis/service/AnalysisProcessingServiceTest.javasrc/test/java/com/mr/domain/analysis/service/AnalysisRecoverySchedulerTest.javasrc/test/java/com/mr/domain/analysis/service/AnalysisServiceTest.javasrc/test/java/com/mr/domain/analysis/service/AnalysisStateServiceTest.javasrc/test/java/com/mr/domain/auth/service/AuthTransactionServiceTest.javasrc/test/java/com/mr/domain/backingtrack/controller/BackingTrackControllerTest.javasrc/test/java/com/mr/domain/history/controller/HistoryControllerTest.javasrc/test/java/com/mr/domain/history/service/HistoryServiceTest.javasrc/test/java/com/mr/domain/home/service/HomeServiceTest.javasrc/test/java/com/mr/domain/mentor/controller/MentorControllerTest.javasrc/test/java/com/mr/domain/mentor/service/MentorServiceTest.javasrc/test/java/com/mr/domain/playing/entity/PlayingTest.javasrc/test/java/com/mr/domain/playing/service/PlayingServiceTest.javasrc/test/java/com/mr/domain/statistics/service/StatisticsAggregationServiceTest.javasrc/test/java/com/mr/domain/statistics/service/StatisticsServiceTest.javasrc/test/java/com/mr/domain/user/controller/UserProfileControllerTest.javasrc/test/java/com/mr/domain/user/service/UserProfileServiceTest.java
ownue
approved these changes
Aug 11, 2026
ownue
left a comment
ownue
left a comment
Contributor
There was a problem hiding this comment.
원정님 코드 리뷰 반영만 되면 더 고칠 점은 없는 것 같습니다! 수고하셨어요~!
on1yoneprivate
approved these changes
Aug 11, 2026
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/resources/db/migration/V7__alter_analysis_time_columns_to_timestamptz.sql`:
- Around line 2-3: V7 마이그레이션 버전 충돌을 해소하도록 두 마이그레이션 중 하나의 버전을 고유한 다음 버전으로 변경하세요.
processing_started_at 변환에서는 복제본과 기존 저장 로직의 레거시 시간 기준을 확인한 뒤, UTC 기준이면 Asia/Seoul
보정을 제거하고 UTC에 맞게 변환하며, 기준이 혼재하면 출처별 보정을 적용하세요.
- Around line 1-7: Resolve the duplicate Flyway V7 migration by renaming one
migration to an unused version, then combine the processing_started_at and
created_at conversions in the same ALTER TABLE statement. Preserve the existing
Asia/Seoul USING conversion after verifying it matches the legacy timestamp
basis, and configure the migration’s operational execution with an appropriate
maintenance window and lock_timeout.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 848de5d2-f4e0-4f2a-afd4-103ad3ae85a9
📒 Files selected for processing (14)
src/main/java/com/mr/domain/analysis/dto/res/AnalysisResultResponseDTO.javasrc/main/java/com/mr/domain/backingtrack/service/BackingTrackService.javasrc/main/java/com/mr/domain/history/dto/res/HistoryDetailResponseDTO.javasrc/main/java/com/mr/domain/history/service/HistoryService.javasrc/main/java/com/mr/domain/playing/dto/res/AnalysisContextResponse.javasrc/main/java/com/mr/domain/playing/dto/res/PlayingStartResponse.javasrc/main/java/com/mr/domain/playing/service/PlayingService.javasrc/main/java/com/mr/global/file/s3/service/S3ObjectKeyGenerator.javasrc/main/resources/application.ymlsrc/main/resources/db/migration/V7__alter_analysis_time_columns_to_timestamptz.sqlsrc/test/java/com/mr/domain/analysis/service/AnalysisServiceTest.javasrc/test/java/com/mr/domain/backingtrack/controller/BackingTrackControllerTest.javasrc/test/java/com/mr/domain/history/service/HistoryServiceTest.javasrc/test/java/com/mr/domain/playing/service/PlayingServiceTest.java
🚧 Files skipped from review as they are similar to previous changes (13)
- src/test/java/com/mr/domain/analysis/service/AnalysisServiceTest.java
- src/main/java/com/mr/domain/playing/dto/res/PlayingStartResponse.java
- src/test/java/com/mr/domain/playing/service/PlayingServiceTest.java
- src/main/java/com/mr/domain/playing/service/PlayingService.java
- src/main/java/com/mr/domain/history/dto/res/HistoryDetailResponseDTO.java
- src/main/java/com/mr/domain/history/service/HistoryService.java
- src/main/java/com/mr/domain/backingtrack/service/BackingTrackService.java
- src/main/java/com/mr/domain/analysis/dto/res/AnalysisResultResponseDTO.java
- src/main/java/com/mr/global/file/s3/service/S3ObjectKeyGenerator.java
- src/test/java/com/mr/domain/backingtrack/controller/BackingTrackControllerTest.java
- src/main/java/com/mr/domain/playing/dto/res/AnalysisContextResponse.java
- src/test/java/com/mr/domain/history/service/HistoryServiceTest.java
- src/main/resources/application.yml
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/main/resources/db/migration/V8__alter_analysis_time_columns_to_timestamptz.sql (1)
1-3: 🩺 Stability & Availability | 🔵 Trivial | 🏗️ Heavy lift대용량
analysis테이블의 잠금과 rewrite를 배포 계획에 반영하세요.Line 2-3은 값 변환을 포함한 컬럼 타입 변경입니다. PostgreSQL은 이런 타입 변경에서 테이블과 인덱스를 재작성할 수 있으며, 대용량 테이블에서는 상당한 시간과 추가 디스크 공간이 필요할 수 있습니다. Squawk도
ACCESS EXCLUSIVE잠금을 보고했습니다. 운영 중에는AnalysisRepository조회와AnalysisRecoveryScheduler작업이 차단될 수 있습니다. (postgresql.org)운영 규모의 데이터베이스 clone에서 실행 시간, 필요한 디스크 공간, 잠금 대기 시간을 측정하세요. 이후 점검 시간대,
lock_timeout, 실패 시 rollback 절차를 정한 뒤 배포하세요. 온라인 변경이 필요하면 expand/backfill/swap 방식으로 마이그레이션을 재설계하세요.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/resources/db/migration/V8__alter_analysis_time_columns_to_timestamptz.sql` around lines 1 - 3, Document the operational migration plan for the ALTER TABLE statements in V8, including clone-based measurements of execution time, disk usage, and lock wait duration, plus a maintenance window, lock_timeout, and rollback procedure. If production downtime is unacceptable, redesign the processing_started_at and created_at conversion using an expand/backfill/swap approach.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@src/main/resources/db/migration/V8__alter_analysis_time_columns_to_timestamptz.sql`:
- Around line 1-3: Document the operational migration plan for the ALTER TABLE
statements in V8, including clone-based measurements of execution time, disk
usage, and lock wait duration, plus a maintenance window, lock_timeout, and
rollback procedure. If production downtime is unacceptable, redesign the
processing_started_at and created_at conversion using an expand/backfill/swap
approach.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: acfb143a-3df3-4ced-a631-c62cb8d136de
📒 Files selected for processing (1)
src/main/resources/db/migration/V8__alter_analysis_time_columns_to_timestamptz.sql
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📍 개요
⛓️💥 관련 이슈
🛠️ 작업 내용
User,Playing,BackingTrack,Analysis,History,Learning,Statistics,Auth)의 날짜/시간 필드를LocalDateTime에서 표준 절대 시간 객체인Instant (UTC)로 전면 교체했습니다.RelativeDateFormatter) 및 S3 파일 키 생성기(S3ObjectKeyGenerator)에 한국 타임존(Asia/Seoul)을 적용하여 뷰 및 파일명 생성 시 정확한 로컬 날짜/시간이 반영되도록 수정했습니다.🔥 리뷰 요청 사항
✅ 체크리스트
📎 참고 사항
Summary by CodeRabbit
개선 사항
설정