[FIX] 히스토리 상세 응답의 미구현 필드 추가 - #169
Merged
Merged
Conversation
📝 WalkthroughWalkthroughHistoryService가 Changes히스토리 상세 마디 지표
애플리케이션 설정 변경
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant HistoryService
participant AnalysisBarCalculator
participant HistoryDetailResponseDTO
HistoryService->>AnalysisBarCalculator: BarMetrics 계산 요청
AnalysisBarCalculator-->>HistoryService: BarMetrics 반환
HistoryService->>HistoryDetailResponseDTO: BarMetrics 전달
HistoryDetailResponseDTO-->>HistoryService: 마디 지표가 포함된 상세 응답 반환
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/main/resources/application.yml (1)
74-75: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win제공 방법과
S3Config의 인증 계약을 맞춰주세요.
application.yml에서는credentials.access-key와credentials.secret-key를 제공하지 않지만,S3Config.java는S3Properties.accessKey()/secretKey()를StaticCredentialsProvider.create(...)에 전달합니다. 설정이 비면 S3 빈 생성이 실패해 애플리케이션 기동이 중단될 수 있습니다.정적 자격 증명을 유지하면
credentials.access-key와credentials.secret-key를 필수 설정/환경 변수로 다시 선언하세요. AWS IAM 역할 또는 기본 자격 증명 체인을 사용하면S3Config를DefaultCredentialsProvider기반으로 변경하고, 선택한 계약을 설정과 함께 검증하세요. 관련 문서: AWS SDK for Java 2.x Credentials Providers, Spring Boot@ConfigurationPropertiesbinding.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/resources/application.yml` around lines 74 - 75, Align the S3 credential configuration with the contract implemented by S3Config: either restore required credentials.access-key and credentials.secret-key environment-backed properties for StaticCredentialsProvider, or update S3Config to use DefaultCredentialsProvider for IAM/default-chain authentication. Ensure the selected credential strategy is consistently represented in application.yml and validated during startup.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/main/resources/application.yml`:
- Around line 74-75: Align the S3 credential configuration with the contract
implemented by S3Config: either restore required credentials.access-key and
credentials.secret-key environment-backed properties for
StaticCredentialsProvider, or update S3Config to use DefaultCredentialsProvider
for IAM/default-chain authentication. Ensure the selected credential strategy is
consistently represented in application.yml and validated during startup.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 8a2017da-9806-4592-940a-6f9a7e795a1c
📒 Files selected for processing (4)
src/main/java/com/mr/domain/history/dto/res/HistoryDetailResponseDTO.javasrc/main/java/com/mr/domain/history/service/HistoryService.javasrc/main/resources/application.ymlsrc/test/java/com/mr/domain/history/service/HistoryServiceTest.java
ownue
requested review from
kimyw1018,
on1yoneprivate,
p1001q and
rkdehdrbs7885-oss
August 8, 2026 15:48
on1yoneprivate
changed the title
rkdehdrbs7885-oss
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📍 개요
⛓️💥 관련 이슈
🛠️ 작업 내용
🔥 리뷰 요청 사항
✅ 체크리스트
📎 참고 사항
X
Summary by CodeRabbit