[FIX] practice-data 응답 midiData에 코드 진행(chords) 반영 - #141
Merged
Conversation
p1001q
requested review from
kimyw1018,
on1yoneprivate,
ownue and
rkdehdrbs7885-oss
August 5, 2026 00:47
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesPractice data 응답 예시
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
피알 본문:
📍 개요
⛓️💥 관련 이슈
🛠️ 작업 내용
recording/options만으로는 화면에 코드 진행을 표시할 수 없어서,midiData안에chords({bar, beat, symbol}배열) 정보가 추가로 필요함을 확인했습니다.midiData는String+@JsonRawValue로playing_example.midi_data(DB JSON 컬럼) 내용을가공 없이 그대로 응답하는 구조라, 백엔드 로직 변경은 없습니다.
LearningPracticeDataResponseDTO의@Schema(example=...)예시 문자열에chords반영한 것 하나뿐입니다(Swagger 문서 정확도 목적).docs/학습·사용자관리 API 명세서.md1-6 섹션(Success Response, 필드 설명 테이블, DB 값 연결)에도동일하게 반영해뒀습니다.
🔥 리뷰 요청 사항
chords구조(bar/beat/symbol)와 맞는지✅ 체크리스트
📎 참고 사항
Summary by CodeRabbit
chords배열을 추가했습니다.