Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False negatives caused by links to text fragments #590

Open
numist opened this issue Apr 27, 2024 · 2 comments
Open

False negatives caused by links to text fragments #590

numist opened this issue Apr 27, 2024 · 2 comments

Comments

@numist
Copy link

numist commented Apr 27, 2024

A link to a text fragment (like this) causes the fragment-check operator to fail, even when the linked text is valid

@nathanchere
Copy link

I think this is still the same issue? Example:

12:08:54 AM:   ✖ FAIL fragment-redirect dist/about/index.html --> dist/about#ourteam --> dist/about/index.html
12:08:54 AM:   | operator: fragment-redirect
12:08:54 AM:   | expected: file:///opt/build/repo/dist/about/#ourteam
12:08:54 AM:   |   actual: https://mydomain.com/about#whoweare
12:08:54 AM:   |       at: dist/about/index.html:6:84293 <a  href="https://mydomain.com/about#ourteam">...</a>

I've had to disable the plugin because this is a deployment blocker.

@numist
Copy link
Author

numist commented May 24, 2024

@nathanchere That is not a link to a text fragment and is likely an actual issue. Changing the link to point directly to the target (eliminating the redirect) ought to give you a better idea of what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants