Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(package): update prettier to version 2.0.1 #176

Merged
merged 8 commits into from
Apr 6, 2020
Merged

chore(package): update prettier to version 2.0.1 #176

merged 8 commits into from
Apr 6, 2020

Conversation

papandreou
Copy link
Collaborator

Closes #175

@papandreou papandreou self-assigned this Mar 22, 2020
@papandreou papandreou requested a review from Munter March 22, 2020 10:36
@papandreou
Copy link
Collaborator Author

@Munter, we can think about whether to align with the prettier 2 defaults of trailingComma and arrowParens. In this first iteration I tried to keep the changes minimal.

papandreou
papandreou commented Mar 22, 2020
View reviewed changes
.travis.yml
include:
- name: Lint
node_js: 12
script: npm run lint
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier 2 doesn't support node 8, so add a build matrix so we only lint with node 12.

@papandreou papandreou mentioned this pull request Mar 24, 2020
Closed
@coveralls
Copy link

coveralls commented Mar 24, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 77.573% when pulling 47f3a63 on greenkeeper/prettier-2.0.1 into 78ff9a5 on master.

@Munter
Copy link
Owner

Munter commented Apr 6, 2020

Awesome

@Munter Munter merged commit 70f203e into master Apr 6, 2020
@greenkeeper greenkeeper bot deleted the greenkeeper/prettier-2.0.1 branch April 6, 2020 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Munter Munter Awaiting requested review from Munter

Assignees

@papandreou papandreou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@papandreou @coveralls @Munter