Run fragment-check when internal flag is true
#153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Munter
force-pushed
the
fix/issue-152-internal-fragments-not-checked
branch
from
03ea714 to
c23bf21
Compare
…ernal flag is active
Munter
force-pushed
the
fix/issue-152-internal-fragments-not-checked
branch
from
c23bf21 to
ad99c47
Compare
…eck should already avoid irrelevant targets being in the set. Closes #152
papandreou
approved these changes
Jul 21, 2019
| @@ -441,13 +449,68 @@ describe('hyperlink', function() { | |||
| t | |||
| ); | |||
|
|
|||
| expect(spyTapCalls(t.push), 'with set semantics to satisfy', [ | |||
There was a problem hiding this comment.
As I mentioned in https://gitter.im/unexpectedjs/unexpected?at=5d3475f2ec5abe7bbc227eab you should be able to use to have calls satisfying here.
Co-Authored-By: Andreas Lind <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152
When running with the
internalflag or--internalin the CLI, fragment checks were not run at all. Also not for completely site internal fragment links.