Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to assetgraph 4 #132

Merged
merged 62 commits into from
Mar 27, 2018
Merged

Update to assetgraph 4 #132

merged 62 commits into from
Mar 27, 2018

Conversation

Munter
Copy link
Owner

@Munter Munter commented Mar 27, 2018 •
edited
Loading

Also includes:

  • Better memory handling by unloading assets
  • Extending population beyond own root for relations that can't cause new pages to be added
  • Passing in own tap render function
  • Tests
  • Fewer retries on 404's
  • Default concurrency to 25
  • Never load assets that are expected to have no outgoing relations

Closes #125 since work continued on this branch

papandreou and others added 30 commits March 12, 2018 23:57
@papandreou
Build with node.js 8 and 9 instead of 4 and 6
4f5b601
@papandreou
Add .npmrc with package-lock = false
b17e9e1
@papandreou
Update assetgraph to ^4.0.0
7b21c63
@papandreou
Update query syntax
1f373e4
@papandreou
es6ify
f56d411
@papandreou
es6/ag4ify
a73f0a2
@papandreou
Add custom populate code
89c50bf
@papandreou
Remove no longer necessary stripping of fragment identifier from asse…
37d5f0c 
…t urls
@papandreou
wip
34a938c
@papandreou
Exclude SvgAnchor relations in non-recursive mode
37becf0
@papandreou
wip
54645d9
@Munter
es6-ify a bit
7fc6970
@Munter
Allow es6 syntax in linter
2ced636
@Munter
Switch linting setup to match Assetgraphs
b014ef9
@Munter
Fix non-style related linting errors
7abcf67
@Munter
Temporarily disable prettier linting plugin to have CI tests pass on …
dd3a216 
…branch
@papandreou
Store a stringified version of the first incoming relation on each as…
73b4157 
…set so that errors can be reported after the source asset has been unloaded
@Munter @papandreou
Allow passing in a TapRender instance as second argument. Should allo…
15ebf8a 
…w for mocked tests
@papandreou
Spike: Add test.
87dc886
@papandreou
Always create (and pipe) the TapRender instance outside of index.js
9f35ab0
@papandreou
Move process.exit calls from index.js to bin/hyperlink
aca354a
@papandreou
Add a test
a0956a0
@papandreou
Test that assets are being unloaded
129042a
@papandreou
Add tests for document fragment checks
0740f35
@papandreou
Add test for 404 checks
af6bd0c
@papandreou
Test <link rel=preconnect href=...>
74f4f75
@papandreou
Arrow function
b45ccb3
@papandreou
Test empty fragments
ddff553
@papandreou
Fix reporting of incoming relations when a <link rel=preconnect href=…
294f7d7 
…...> points at a host that cannot be connected to
@Munter
Add Coveralls dependency
84b59bd
Munter and others added 28 commits March 17, 2018 23:24
@Munter
Remove unused variable and moved const into else branch
5da6336
@papandreou
Convert querySelectorAll result to array before iterating
ead5172
@papandreou
Disable fragment checks for SVGs (querySelectorAll not supported)
1cf94ef
@papandreou
Handle <link rel=dns-prefetch> similar to preconnect, fixes #126
023d1b7
@papandreou
tryConnect: Destroy the socket after successfully connecting
3cdac89
@papandreou
Follow crossorigin relations to assets that are loaded with the page
ce2bee1 
The purpose is to detect 404s that would occur during the page load
due to errors in the next level(s) of relations.

Moves the mixed content warning check into processAsset instead
of being a side effect of logResult

Similar to Munter/subfont#15
@papandreou
Fix disabled eslint warning
46240c0
@papandreou
Test (and fix up) excludePatterns
f2d0678
@papandreou
Test and sort out handling of HTTP redirects
ba6f738 
Apparently there was an API change in the request module that
caused us to always conclude that no redirects happened.
@Munter
Super verbose memory debugging
1c78bf1
@papandreou
Fix ReferenceError and unused var in memory debugging code
9b0a054
@papandreou
Also log when unloading in verbose mode
ba1b388
@papandreou
Destructure the options object
6e0a998
@papandreou
Log when unloading an asset
c7fe670
@papandreou
Honor --concurrency again
3e7d523
@papandreou
Lower default concurrency to 25
92e01f7
@Munter
Merge branch 'feature/assetgraph4' into feature/followCrossorigin
f147d7e
@Munter
Fix lint errors
7bf1ae3
@papandreou
Update assetgraph to ^4.0.5 (fixes Html memory leak)
3dc8da0
@papandreou
Sort out mixed content warnings now that relations to other origins a…
50ba9bd 
…re followed
@Munter
Avoid both reporting ok and fail on a failed load. Only report ok on …
136d31e 
…successful load of an asset
@Munter
Remove nonsensical integrtion test
42fb8ed
@Munter
Merge branch 'feature/followCrossorigin' into feature/assetgraph4
bcf9ddf 
* feature/followCrossorigin:
  Remove nonsensical integrtion test
  Sort out mixed content warnings now that relations to other origins are followed
  Fix lint errors
  Follow crossorigin relations to assets that are loaded with the page
@papandreou @Munter
Don't load assets that are expected not to have outgoing relations, j…
51078e2 
…ust HEAD them at the end
@Munter
Don't retry GET two times on a 404 HEAD request. Adjust test for new …
9a15d0a 
…base branch
@Munter
Merge pull request #129 from Munter/fix/excludePatterns
5f7edac 
Test (and fix up) excludePatterns
@Munter
Merge pull request #130 from Munter/feature/onlyHeadAssetsWithoutOutg…
65a8626 
…oingRelations

Only HEAD assets without outgoing relations
@Munter
Update assetgraph to 4.1.1
2e448c6
@Munter Munter merged commit 1245656 into master Mar 27, 2018
@Munter Munter deleted the feature/assetgraph4 branch March 27, 2018 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Munter @papandreou