Fix bug where fragment checks would be executed to links to external …

…pages that were never loaded when runnin in internal mode
Munter · Aug 15, 2019 · 5593490 · 5593490
1 parent 3189efe
commit 5593490
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 3 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -685,7 +685,8 @@ async function hyperlink(
 
   for (const asset of ag.findAssets({
     type: 'Html',
-    incomingFragments: { $exists: true }
+    incomingFragments: { $exists: true },
+    ids: { $exists: true }
   })) {
     for (const {
       fragment,
@@ -701,7 +702,7 @@ async function hyperlink(
       };
 
       if (!shouldSkip(fragmentReport)) {
-        if (asset.ids && asset.ids.has(fragment.substr(1))) {
+        if (asset.ids.has(fragment.substr(1))) {
           reportTest({
             ...fragmentReport,
             ok: true,
@@ -711,7 +712,6 @@ async function hyperlink(
           // Github does some weird things with mangling fragments and reversing it with runtime js
           if (
             asset.origin === 'https://github.com' &&
-            asset.ids &&
             asset.ids.has(`user-content-${fragment.substr(1)}`)
           ) {
             reportTest({

diff --git a/test/index.js b/test/index.js
@@ -2295,6 +2295,42 @@ describe('hyperlink', function() {
       ]);
       expect(t.close(), 'to satisfy', { fail: 1 });
     });
+
+    it('should not follow fragment links to external pages', async () => {
+      httpception([
+        {
+          request: 'GET https://test.com',
+          response: {
+            headers: {
+              'content-type': 'text/html'
+            },
+            body:
+              '<a href="https://nodejs.org/api/events.html#events_class_eventemitter"></a>'
+          }
+        }
+      ]);
+
+      const t = new TapRender();
+      // t.pipe(process.stderr);
+      sinon.spy(t, 'push');
+      await hyperlink(
+        {
+          root: 'https://test.com',
+          inputUrls: ['https://test.com'],
+          internalOnly: true
+        },
+        t
+      );
+
+      expect(spyTapCalls(t.push), 'to satisfy', [
+        {
+          operator: 'load',
+          name: 'load https://test.com',
+          ok: true
+        }
+      ]);
+      expect(t.close(), 'to satisfy', { pass: 1, fail: 0 });
+    });
   });
 
   describe('with Html responses in non-navigation relations', function() {