Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend for backups in v2.5.15 #94

Closed
MuntashirAkon opened this issue Sep 4, 2020 · 1 comment
Closed

Frontend for backups in v2.5.15 #94

MuntashirAkon opened this issue Sep 4, 2020 · 1 comment
Labels
Feature New feature or request Priority: 0 Highest priority
Milestone
v2.5.15

Comments

@MuntashirAkon
Copy link
Owner

MuntashirAkon commented Sep 4, 2020 •
edited
Loading

Batch Ops. If multiple backup is turned on, the user will be shown a new dialog box to input the name of the backup along with the regular multichoice dialog. This name is optional, and if it's not given, current date time will be used instead. For restore/delete backup is requested for multiple packages, only the default backups (ie. the ones associated with the user id, not the named backups) will be restored/deleted. For a single package, the behaviour will be similar to App Info tab.

App Info tab. For restore/delete a single choice list of current backups will be displayed along with backup name, date, version, backup types (apk/data/rules/all) and user handle (user id).

  • Delete backup and restore should have confirmation prompts
  • Backup should have a confirmation prompt if a backup already exists
@MuntashirAkon MuntashirAkon added Feature New feature or request Priority: 0 Highest priority labels Sep 4, 2020
@MuntashirAkon MuntashirAkon added this to the v2.5.14 milestone Sep 4, 2020
@MuntashirAkon MuntashirAkon mentioned this issue Sep 8, 2020
Closed
@MuntashirAkon MuntashirAkon changed the title Frontend for backups in v2.5.14 Frontend for backups in v2.5.15 Sep 13, 2020
@MuntashirAkon
Copy link
Owner Author

Postponed for the deadline is over.

@MuntashirAkon MuntashirAkon modified the milestones: v2.5.14, v2.5.15 Sep 13, 2020
MuntashirAkon added a commit that referenced this issue Sep 18, 2020
@MuntashirAkon
[Backup] Display alert before deleting/restoring backups
92bd71d 
Related issue #94

When multiple backups is requested for all users, the solution was to create multiple backups by adding arbitrary numbers after the backup name. This solution is quite hacky and the best option is to append the user ID before the name to get unique names from the same backup name. But base backups will only have the user IDs.

Also, it is necessary to sanitise user inputs since they might contain illegal characters such as NULL or / (slash).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New feature or request Priority: 0 Highest priority
Projects
None yet
Milestone
v2.5.15
Development

No branches or pull requests
1 participant
@MuntashirAkon