Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACF Command rework - Done! #610

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

ACF Command rework - Done! #610

wants to merge 29 commits into from

Conversation

benwoo1110
Copy link
Member

@benwoo1110 benwoo1110 commented Dec 28, 2020 •
edited
Loading

This PR reworks Multiverse-Portals commands to complement the changes from Multiverse/Multiverse-Core#2514.

Command Changes:

  • /mvp config list instead of /mvp config show to be consistent with the rest of the modules.
  • No longer need -p flag for mvp modify <property> <value> [portal] command.

API Changes:

  • Changed PortalConfigProperty to a class instead, so each property can have its value datatype defined as well. Similar to bukkit's GameRule class.
  • Remove some redundant SetProperties enum alias.
  • Add setHereDestination to MVPortal class.
  • setDestination in MVPortal overload to set portal desination with MVDestination directly.

You can get the test builds at https://www.benergy10.dev/

@benwoo1110
Prepare MV-Portals for ACF intergration.
0bf6b99
@benwoo1110
Setup and add config command.
e16b5cb
@benwoo1110
Add debug command.
6ce805b
@benwoo1110
Add select command.
eb93f34
@benwoo1110
Use toggles completion.
9ae4021
@benwoo1110
Add PortalPlayerSession context.
c46efb0
@benwoo1110
Add list command.
b167e9e
@benwoo1110
Add remove command.
2446a0c
@benwoo1110
Add wand command.
21fa04a
@benwoo1110
Add info command.
38c4787
@benwoo1110
Add root command to show plugin info.
d0d67b5
@benwoo1110
Cleanup plugin.yml
cd4a243
@benwoo1110
Update mv-core dependency.
32cab8d
@benwoo1110
Update mv-core depenency.
efb8f99
@benwoo1110
Use new registerSubModule method.
9b88733
@benwoo1110
Add usage command with description and some cleanup.
7469352
@benwoo1110
Update mv-core dependency.
2f92396
@benwoo1110
Set portal desination with MVDestination directly.
b4ae4f1
@benwoo1110
Add create command.
407ed2f
@benwoo1110
Move setHereDestination to MVPortal class.
234d87e
@benwoo1110
Add modify command.
4e564ec
@benwoo1110
Cleanup and remove old command code.
e357526
@benwoo1110
Update PageDisplay to accomodate core changes.
73fce1b
@benwoo1110
Update for new ContentDisplay api changes.
5232cbb
@benwoo1110
Improve MVPortals#setDestination to be player aware.
88a61d7
@benwoo1110
Update create and modify command with new setDestination method.
385fb7e
@benwoo1110
Use string format in favour on concatination.
3f55eb6
@benwoo1110
Update list command content format and colours.
1e9f903
@benwoo1110
Minor fix to modify command messages.
5bf0b51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benwoo1110