Skip to content

Fix observable set cannot override #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Fix observable set cannot override #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d8f22f
fix: CKEditorError: observable-set-cannot-override
jamieconnelly Oct 21, 2024
7042313
chore: bump version
jamieconnelly Oct 21, 2024
759263a
chore: update CHANGELOG.md
jamieconnelly Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

- Add latest changes here

## [v43.2.0-next.1](https://github.com/Multiverse-io/ckeditor5-math/compare/v43.2.0-next.0...v43.2.0-next.1) (2024-10-21)

- Fixes `CKEditorError: observable-set-cannot-override` error. See - https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-observable-set-cannot-override

## [v43.2.0-next.0](https://github.com/Multiverse-io/ckeditor5-math/compare/v43.2.0...v43.2.0-next.0) (2024-10-21)

- Bootstrap CI
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@multiverse-io/ckeditor5-math",
"version": "43.2.0-next.0",
"version": "43.2.0-next.1",
"description": "Math feature for CKEditor 5.",
"keywords": [
"ckeditor",
Expand Down
6 changes: 2 additions & 4 deletions src/ui/mathview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import type { KatexOptions } from '../typings-external.js';
import { renderEquation } from '../utils.js';

export default class MathView extends View {
public value: string;
public display: boolean;
public declare value: string;
public declare display: boolean;
public previewUid: string;
public previewClassName: Array<string>;
public katexRenderOptions: KatexOptions;
Expand Down Expand Up @@ -38,9 +38,7 @@ export default class MathView extends View {
this.previewClassName = previewClassName;

this.set( 'value', '' );
this.value = '';
this.set( 'display', false );
this.display = false;

this.on( 'change', () => {
if ( this.isRendered ) {
Expand Down