✨Factory function for building plotly plot functions #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns for common theming to simplify functions and avoid redundant code
…y function to encapsulate common code to build all plots
…er plots by using the plot_builder factory function
sayalaruano
changed the title
enryH
reviewed
Sep 11, 2025
enryH
reviewed
Sep 11, 2025
| } | ||
|
|
||
| # Apply preprocessing if provided | ||
| if preprocess: |
There was a problem hiding this comment.
maybe we can add a if preprocess is callable?
|
…ocess variable Co-authored-by: Henry Webel <[email protected]>
…ng import and add validation of preprocess to be callable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create a factory function to abstract the steps required to build plotly plots in the engine functions. In this way, we avoid writing redundant code in every plot file.
List of changes proposed in this PR (pull-request)
vuecore/plots/plot_buildery.pyfunctionvuecore/engines/plotly/__init__.pyto register functions and limit wat is imported with *vuecore/engines/plotly/engines/plotly/bar.py,vuecore/engines/plotly/box,vuecore/engines/plotly/line, andvuecore/engines/plotly/scatterengine functionsvuecore/engines/plotly/theming.pyscript by adding helper functions for common tasks