Skip to content

Conversation

@sayalaruano
Copy link
Collaborator

No description provided.

@sayalaruano sayalaruano requested a review from enryH August 13, 2025 07:37
Copy link
Collaborator

@enryH enryH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some ideas and questions.

into the arguments for `plotly.express.scatter`.
Plotly Express implementation. It translates the validated `ScattereConfig`
into the arguments for `plotly.express.scatter` and also forwards any
additional, unvalidated keyword arguments from plotly. The resulting figure
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you will add all plotly arguments per default?

Copy link
Collaborator Author

@sayalaruano sayalaruano Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I added the most important ones, but also enabled passing extra arguments from plotly express. Do you think that would be better to just add all of them?

* **Jupyter Notebook:** `docs/api_examples/scatter_plot.ipynb` -
https://vuecore.readthedocs.io/en/latest/api_examples/scatter_plot.html
* **Python Script:** `docs/api_examples/scatter_plot.py`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to have the link to GitHub?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will add the link for the Python Script on GitHub.

a scatter plot, from data mapping to styling and layout. It ensures that
user-provided configurations are type-safe and adhere to the expected structure.
This model serves as a curated API for the most relevant parameters
for scatter plots, closely aligned with the `plotly.express.scatter` API
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is a one-to-one mapping we could check is in a script with the default function parameters of the plotly function. the inspect module can do that, but there are probably other ways as well to list the parameter.

import inspect
import plotly.express as px

signature = inspect.signature(px.scatter)

This returns a signature object which has the name as keys (signature.parameters)

@sayalaruano sayalaruano merged commit 013c068 into main Aug 13, 2025
9 checks passed
@sayalaruano sayalaruano deleted the updt-scatterplot branch August 13, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants