Add logo #10
Merged
Add logo #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pip package: with hyphen - import: with underscore
|
It now builds on readthedocs, see link. However, the logo is not rendered correctly it seems. You can see the logs or also set it up locally: https://app.readthedocs.org/projects/vuecore/builds/28570791/ WARNING: logo file 'images/vuecore_logo.svg' does not exist
WARNING: favicon file 'images/vuecore_logo.svg' does not existI leave it to you to figure this out:) |
|
Hey @enryH! I just replaced the static path to the link of the images in this branch, now it looks good - https://vuecore--10.org.readthedocs.build/en/10/. Let me know if it's ok, and I will replace the logo links to the main branch instead and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.