-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
IJSRuntimeExtensions: Adjust pre-rendering handling for .NET8 #9997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9997 +/- ##
==========================================
+ Coverage 89.82% 90.96% +1.13%
==========================================
Files 412 408 -4
Lines 11878 12594 +716
Branches 2364 2451 +87
==========================================
+ Hits 10670 11456 +786
+ Misses 681 581 -100
- Partials 527 557 +30 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Added to v8.0.0 Migration Guide #9953 |
7 tasks
7 tasks
LLauter
pushed a commit
to cannellamedia/MudBlazor
that referenced
this pull request
Dec 16, 2024
This was referenced Aug 18, 2025
This was referenced Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
This change will require consumer code updates
bug
Unexpected behavior or functionality not working as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed
IIJSRuntimeExtensionstoIJSRuntimeExtensions, not sure why there was two "I" at start.We already renamed it from
IIJSRuntimeExtentionstoIIJSRuntimeExtensionsin #9582.The following line:
no longer works in .NET 8. See: #7155.
Even though we addressed the issue a long time ago by using
IsJsInteropAvailableand calling JS only when it's true, I still believe it's good idea to handle this case. Otherwise, the line above will not do anything, and this solution is slightly more reliable than checking the message text that has changed in .NET 8.How Has This Been Tested?
Added test for this.
Type of Changes
Checklist
dev).