Skip to content

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Oct 12, 2024

Description

Renamed IIJSRuntimeExtensions to IJSRuntimeExtensions, not sure why there was two "I" at start.
We already renamed it from IIJSRuntimeExtentions to IIJSRuntimeExtensions in #9582.

The following line:

catch (InvalidOperationException ex) when (ex.Message.Contains("prerender", StringComparison.InvariantCultureIgnoreCase))

no longer works in .NET 8. See: #7155.

Even though we addressed the issue a long time ago by using IsJsInteropAvailable and calling JS only when it's true, I still believe it's good idea to handle this case. Otherwise, the line above will not do anything, and this solution is slightly more reliable than checking the message text that has changed in .NET 8.

How Has This Been Tested?

Added test for this.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Oct 12, 2024
@codecov
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (28bc599) to head (3cb9276).
Report is 556 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9997      +/-   ##
==========================================
+ Coverage   89.82%   90.96%   +1.13%     
==========================================
  Files         412      408       -4     
  Lines       11878    12594     +716     
  Branches     2364     2451      +87     
==========================================
+ Hits        10670    11456     +786     
+ Misses        681      581     -100     
- Partials      527      557      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro changed the title IIJSRuntimeExtensions: Adjust pre-rendering handling for .NET8 IJSRuntimeExtensions: Adjust pre-rendering handling for .NET8 Oct 12, 2024
@ScarletKuro ScarletKuro added breaking change This change will require consumer code updates v8 and removed PR: needs review labels Oct 12, 2024
@ScarletKuro
Copy link
Member Author

Added to v8.0.0 Migration Guide #9953

@ScarletKuro ScarletKuro merged commit 9589a76 into MudBlazor:dev Oct 12, 2024
4 checks passed
@ScarletKuro ScarletKuro deleted the Jsruntime_improve branch October 12, 2024 21:13
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change This change will require consumer code updates bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant